Fix for: Cannot read property 'classes' of undefined #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexBeauchemin
changed the title
houndci-bot
reviewed
Apr 12, 2018
| if (err) { | ||
| console.log(err); | ||
| } | ||
| console.log("Deleted the badge file " + coverageBadgePath); |
|
|
||
| fs.unlink(coverageBadgePath, function(err) { | ||
| if (err) { | ||
| console.log(err); |
| expect(err).to.be.null; | ||
| expect(badgeStatus).to.be.an("object"); | ||
|
|
||
| console.log(badgeStatus); |
| fs.stat(coverageBadgePath, function gettingStats(err, stats) { | ||
| expect(err).to.be.null; | ||
| expect(stats).to.be.an("object"); | ||
| expect(stats.isFile()).to.be.true; |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression.
|
|
||
| // Verify that the badge file was successfully created | ||
| fs.stat(coverageBadgePath, function gettingStats(err, stats) { | ||
| expect(err).to.be.null; |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression.
| console.log(badgeStatus); | ||
|
|
||
| var fileWithExtension = opts.badgeFileName + ".svg"; | ||
| var coverageBadgePath = path.normalize(path.resolve(destinationDir, fileWithExtension)); |
|
|
||
| // Load the badge for the report | ||
| badger(opts, function parsingResults(err, badgeStatus) { | ||
| expect(err).to.be.null; |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression.
| var opts = { | ||
| badgeFileName: "coverage-multiple-without-classes", | ||
| destinationDir: destinationDir, | ||
| istanbulReportFile: path.resolve(__dirname, "fixture", "istanbul-report-multiple-packages-without-classes.xml") |
There was a problem hiding this comment.
Line is too long.
'__dirname' is not defined.
| @@ -94,6 +94,47 @@ describe("istanbul-cobertura-badger", function() { | |||
| }); | |||
| }); | |||
|
|
|||
| it("should compute overall coverage over packages without classes and create the badge", function(done) { | |||
|
Still this issue exists. Waiting for the PR to be merged. |
|
This is ready to be merged but I think the maintainers are gone 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allow to handle different xml structures
In my case, the cobertura-coverage.xml had a different structure that made the lib crash:
Using
"istanbul": "v1.1.0-alpha.1"
"remap-istanbul": "^0.9.5"
"mocha": "^3.5.3"