feat: support overriding feed filenames #1030
Conversation
| url: !model.url || validator.isURL(model.url) | ||
| name: !!model.name && model.name.length > 0, | ||
| url: !model.url || validator.isURL(model.url), | ||
| filename: !model.filename || (/^[^<>:"/\\|?* ]*$/.test(model.filename) && !/\.zip$/i.test(model.filename)) |
There was a problem hiding this comment.
What is the first .test() doing? (Add a comment)
There was a problem hiding this comment.
This line might not be passing flow.
There was a problem hiding this comment.
they're both checking the regexes, but the regexes do different things.
| @@ -195,6 +199,21 @@ export default class CreateFeedSource extends Component<Props, State> { | |||
| </small> | |||
| </FormGroup> | |||
| </ListGroupItem> | |||
| <ListGroupItem> | |||
| <FormGroup validationState={validationState(validation.filename)}> | |||
| <ControlLabel>Override filename for bundle (optional)</ControlLabel> | |||
There was a problem hiding this comment.
Did you intend to use a localized message here too?
There was a problem hiding this comment.
I didn't use the localized messages in this file because nothing else here is localized and I didn't want to add support for localization as part of this PR because it felt out of scope. I haven't looked into how to get the localization object into a component though, so I don't know how hard it is.
| disabled={!model.deployable} | ||
| name={'filename'} | ||
| placeholder='e.g., agency_bundle.zip' | ||
| onChange={this._onInputChange('filename')} |
There was a problem hiding this comment.
Show stopper: Typing the suggested file name followed by ".zip" crashes the "Create Feed Source" UI. (There is no crash when editing an existing feed.)
There was a problem hiding this comment.
I wasn't able to replicate the crash, maybe I fixed it through other fixes
daniel-heppner-ibigroup
assigned binh-dam-ibigroup and unassigned daniel-heppner-ibigroup
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
| @@ -759,6 +764,7 @@ components: | |||
| title: Log in | |||
| ManagerHeader: | |||
| noUpdateYet: n/a | |||
| bundleFilename: Bundle Filename | |||
There was a problem hiding this comment.
Can you not re-use the string from feed info?
There was a problem hiding this comment.
annoyingly, the way the internationalization works in DT is that the key is already scoped to ManagerHeader inside the ManagerHeader component, so you can't reach to other strings.
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
Checklist
devbefore they can be merged tomaster)Description
This PR adds support for overriding the feed filenames that will be used in the bundle. This feature allows us to override feed specific build settings in the build config.