Skip to content

docs(icons): enhance icon picker documentation and add search component #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ajnart
Copy link
Contributor

@ajnart ajnart commented Apr 24, 2025

(it's for backlinks)

Copy link

netlify bot commented Apr 24, 2025

Deploy Preview for homarr-docs ready!

Name Link
🔨 Latest commit 6a82edc
🔍 Latest deploy log https://app.netlify.com/sites/homarr-docs/deploys/680b2dafc86ae6000839b552
😎 Deploy Preview https://deploy-preview-283--homarr-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 41 (🟢 up 4 from production)
Accessibility: 96 (no change from production)
Best Practices: 83 (no change from production)
SEO: 97 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

argos-ci bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 13 changed Apr 25, 2025, 6:43 AM

Comment on lines 15 to 21
<input
type="text"
value={searchTerm}
onChange={(e) => setSearchTerm(e.target.value)}
placeholder="Search for icons on dashboardicons.com..."
className="w-full px-4 py-2 text-gray-700 bg-white border rounded-lg focus:outline-none focus:border-blue-500"
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix darkmode:
image

<input
type="text"
value={searchTerm}
onChange={(e) => setSearchTerm(e.target.value)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
onChange={(e) => setSearchTerm(e.target.value)}
onChange={(event) => setSearchTerm(event.target.value)}

export const IconSearch = () => {
const [searchTerm, setSearchTerm] = useState('');

const handleSubmit = (e: React.FormEvent) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const handleSubmit = (e: React.FormEvent) => {
const handleSubmit = (event: React.FormEvent) => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants