Skip to content

ci(versioning): Generate version after Helm chart sync #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oben01
Copy link
Member

@oben01 oben01 commented Apr 5, 2025

No description provided.

@oben01 oben01 self-assigned this Apr 5, 2025
Copy link

netlify bot commented Apr 5, 2025

Deploy Preview for homarr-docs ready!

Name Link
🔨 Latest commit ba2e8bd
🔍 Latest deploy log https://app.netlify.com/sites/homarr-docs/deploys/67f2c3d91e23e300084a8ee1
😎 Deploy Preview https://deploy-preview-267--homarr-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 46 (🟢 up 6 from production)
Accessibility: 96 (no change from production)
Best Practices: 83 (no change from production)
SEO: 97 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

argos-ci bot commented Apr 5, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 changed Apr 6, 2025, 6:38 PM

@oben01 oben01 force-pushed the feature/automatic-versioning branch from 59e573d to ba2e8bd Compare April 6, 2025 18:11
@oben01 oben01 requested a review from Meierschlumpf April 6, 2025 19:18
@oben01 oben01 marked this pull request as ready for review April 6, 2025 19:18
@ajnart ajnart force-pushed the master branch 3 times, most recently from a518369 to be5bd57 Compare April 18, 2025 05:46
@ajnart
Copy link
Contributor

ajnart commented Apr 18, 2025

The website keeps getting bigger and bigger, which eats up our github repo's bandwidth and explodes the number of web pages indexed / generated

Why not have just latest and next ?

It would make sense to have such a version switcher for a big jump like 0.15.3 to 1.16.0 but other than that changes are pretty minor, so having only latest and next would make more sense imo.

@oben01
Copy link
Member Author

oben01 commented Apr 19, 2025

Thank u @ajnart for your feedback I am bit busy at the moment. @Meierschlumpf @manuel-rw what do u thing guys ?!

@Meierschlumpf
Copy link
Member

IMO it's nice to have at least a few versions around, but I agree that we can probably remove some of them already (we started with 1.10.0 and are currently at 1.17.0 (also if our docs are at version 1.15.0 currently because there were no changes in between for the docs

Comment on lines +3 to +6
on:
push:
branches:
- master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: Add a workflow dispatch?

git config user.email "github-actions[bot]@users.noreply.github.com"
git add .
git commit -m "docs(version): Add versioned docs for ${{ steps.get-version.outputs.version }}" || echo "No changes to commit"
git push
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this result in an infinite loop (see triggers?)

@@ -0,0 +1,68 @@
name: "[Docs] Generate version after Helm chart sync"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name is misleading, nothing is done here with a helm chart sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants