-
Notifications
You must be signed in to change notification settings - Fork 42
ci(versioning): Generate version after Helm chart sync #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for homarr-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
59e573d
to
ba2e8bd
Compare
a518369
to
be5bd57
Compare
The website keeps getting bigger and bigger, which eats up our github repo's bandwidth and explodes the number of web pages indexed / generated Why not have just It would make sense to have such a version switcher for a big jump like |
Thank u @ajnart for your feedback I am bit busy at the moment. @Meierschlumpf @manuel-rw what do u thing guys ?! |
IMO it's nice to have at least a few versions around, but I agree that we can probably remove some of them already (we started with |
on: | ||
push: | ||
branches: | ||
- master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Add a workflow dispatch?
git config user.email "github-actions[bot]@users.noreply.github.com" | ||
git add . | ||
git commit -m "docs(version): Add versioned docs for ${{ steps.get-version.outputs.version }}" || echo "No changes to commit" | ||
git push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this result in an infinite loop (see triggers?)
@@ -0,0 +1,68 @@ | |||
name: "[Docs] Generate version after Helm chart sync" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name is misleading, nothing is done here with a helm chart sync
No description provided.