feat: improve design (i guess) #265
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for homarr-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Meierschlumpf
requested changes
Apr 5, 2025
ajnart
requested review from
Meierschlumpf,
SeDemal,
manuel-rw,
lammersbjorn,
a team and
Copilot
There was a problem hiding this comment.
Copilot reviewed 13 out of 17 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- .vscode/settings.json: Language not supported
- package.json: Language not supported
- pnpm-lock.yaml: Language not supported
- src/css/custom.css: Language not supported
Comments suppressed due to low confidence (1)
src/components/pages/home/dataflow/dataflow.tsx:137
- The interval timer is not cleared on component unmount, which may lead to memory leaks. Consider using useEffect with a cleanup function to clear the timer.
const timer = setInterval(() => { if (start.current) { ... }
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Meierschlumpf
requested changes
Apr 11, 2025
| </div> | ||
| <div className="flex-grow-1 w-full lg:block hidden hover-animation"> | ||
|
|
||
| <div className="hover-animation"> |
There was a problem hiding this comment.
We should still hide the widgets on smaller screens. Otherwise it looks bad
| <props.icon size={40} /> | ||
| <div className="group p-4 rounded-2xl transition-all duration-300"> | ||
| <div className="flex flex-col sm:flex-row items-start sm:items-center gap-4 mb-3"> | ||
| <div className="rounded-xl ml-4 bg-gray-100 dark:bg-zinc-800 p-3 shadow-sm group-hover:shadow-md group-hover:scale-110 transition-all duration-300"> |
There was a problem hiding this comment.
The margin should be removed
There was a problem hiding this comment.
Also the icon is not centered
There was a problem hiding this comment.
On mobile we should add margins:
ajnart
force-pushed
the
master
branch
3 times, most recently
from
a518369 to
be5bd57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.