Skip to content

Use TextStyle for iconStyle #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use TextStyle for iconStyle #55

wants to merge 1 commit into from

Conversation

peterkuiper
Copy link

Fixes #53

@himelbrand
Copy link
Owner

Thanks a lot for your contribution!
Please make it possible to use one or the other... depending on need

@jarod-legault
Copy link

jarod-legault commented May 30, 2024 •
edited
Loading

@himelbrand I'm not sure why there should be an option of different types for iconStyle. If you look at IconProps from react-native-vector-icons/Icon, it extends TextProps from react-native, which in turn uses TextStyle for the style prop. It seems like this PR is correct and will eliminate Typescript errors for users, specifically when attempting to set the color of the icons. But maybe I am misunderstanding your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - ViewStyle does not allow color
3 participants
@peterkuiper @himelbrand @jarod-legault