Add support for long press functionality. #39
Conversation
There was a problem hiding this comment.
Thanks @scarfex,
I reviewed your PR and I added comments on little cosmetic changes that need to be made.
| @@ -32,6 +32,10 @@ export default class NumericInput extends Component { | |||
| updateBaseResolution = (width, height) => { | |||
| calcSize = create({ width, height }) | |||
| } | |||
|
|
|||
| startInc = () => {this.inc(); this.incInterval = setInterval(this.inc, 100); } | |||
| startDec = () => {this.dec(); this.decInterval = setInterval(this.dec, 100); } | |||
There was a problem hiding this comment.
please change them to be spread on a few lines, like the other functions, please
There was a problem hiding this comment.
since they have more than one command
also please remove the semicolon from the end of lines, please
| @@ -60,6 +64,17 @@ export default class NumericInput extends Component { | |||
| this.props.onChange && this.props.onChange(Number(value)) | |||
| this.setState({ value, stringValue: value.toString() }) | |||
| } | |||
|
|
|||
| stopInc = () => { | |||
|
|
|||
| } | ||
|
|
||
| stopDec = () => { | ||
|
|
|
|
||
| stopDec = () => { | ||
|
|
||
| clearInterval(this.decInterval); |
|
|
||
| stopInc = () => { | ||
|
|
||
| clearInterval(this.incInterval); |
|
also, I just noticed that the PR is into the master branch. |
|
@scarfex until you make the requested changes the PR won't be approved. |
|
This would be a nice addition, @scarfex please implement the small changes so we can enjoy it |
Found a way to change values quicker with a long press of the increase or decrease buttons.