Skip to content

chore: introduce new FileId methods for non zero shard and realm hand… #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 29, 2025

Conversation

naydenovn
Copy link
Contributor

@naydenovn naydenovn commented Apr 23, 2025

Description:
Adds APIs for non-zero realm and shard AddressBook retrieving
Introduces new forMirrorNetwork method that handles non-zero realm and shard for specific FileId (non-zero AddressBook)

Related issue(s):

Fixes #2305

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…ling together with forMirrorNetwork method

Signed-off-by: Naydenov <nikola.naydenov@limechain.tech>
@naydenovn naydenovn self-assigned this Apr 23, 2025
@naydenovn naydenovn requested review from a team as code owners April 23, 2025 13:43
@naydenovn naydenovn requested a review from agadzhalov April 23, 2025 13:43
Signed-off-by: Naydenov <nikola.naydenov@limechain.tech>
Signed-off-by: Naydenov <nikola.naydenov@limechain.tech>
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...src/main/java/com/hedera/hashgraph/sdk/Client.java 41.66% 7 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
...src/main/java/com/hedera/hashgraph/sdk/FileId.java 60.00% <100.00%> (ø) 16.00 <3.00> (?)
...src/main/java/com/hedera/hashgraph/sdk/Client.java 81.20% <41.66%> (ø) 107.00 <0.00> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Naydenov <nikola.naydenov@limechain.tech>
Signed-off-by: Naydenov <nikola.naydenov@limechain.tech>
Signed-off-by: Naydenov <nikola.naydenov@limechain.tech>
0xivanov
0xivanov previously approved these changes Apr 28, 2025
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Naydenov <nikola.naydenov@limechain.tech>
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov 0xivanov merged commit c5b366b into main Apr 29, 2025
6 checks passed
@0xivanov 0xivanov deleted the 2305-non-zero-realm-and-shard-fileIds-for-static-files branch April 29, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-Zero Realm and Shard File IDs for Static Files
2 participants