Skip to content

Commit 2f3ed43

Browse files
committed
Fix subscribe() iterator
1 parent 39a8e91 commit 2f3ed43

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

src/graphql/execution/incremental_publisher.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -397,8 +397,7 @@ async def subscribe(
397397

398398
if result is not None:
399399
yield result
400-
401-
if not is_done:
400+
else:
402401
await self._resolve.wait()
403402
finally:
404403
close_async_iterators = []

tests/execution/test_defer.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -782,7 +782,6 @@ async def handles_async_non_nullable_errors_thrown_in_deferred_fragments():
782782

783783
@pytest.mark.asyncio()
784784
async def returns_payloads_in_correct_order():
785-
return # TODO: hangs
786785
document = parse(
787786
"""
788787
query HeroNameQuery {
@@ -836,7 +835,6 @@ async def returns_payloads_in_correct_order():
836835

837836
@pytest.mark.asyncio()
838837
async def returns_payloads_from_synchronous_data_in_correct_order():
839-
return # TODO: hangs
840838
document = parse(
841839
"""
842840
query HeroNameQuery {

0 commit comments

Comments
 (0)