Skip to content

Commit 39a8e91

Browse files
committed
Fix add_task() method
1 parent 5437ca5 commit 39a8e91

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/graphql/execution/execute.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1724,7 +1724,7 @@ async def execute_stream_async_iterator(
17241724
previous_incremental_data_record = incremental_data_record
17251725
index += 1
17261726

1727-
async def add_task(self, awaitable: Awaitable[Any]) -> None:
1727+
def add_task(self, awaitable: Awaitable[Any]) -> None:
17281728
"""Add task."""
17291729
tasks = self._tasks
17301730
task = ensure_future(awaitable)

src/graphql/execution/incremental_publisher.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,8 @@ async def subscribe(
386386
while not is_done:
387387
released = self._released
388388
for item in released:
389-
del pending[item]
389+
if item in pending:
390+
del pending[item]
390391
self._released = {}
391392

392393
result = self._get_incremental_result(released)
@@ -592,7 +593,7 @@ def _matches_path(
592593
) -> bool:
593594
return all(item == test_path[i] for i, item in enumerate(base_path))
594595

595-
async def _add_task(self, awaitable: Awaitable[Any]) -> None:
596+
def _add_task(self, awaitable: Awaitable[Any]) -> None:
596597
tasks = self._tasks
597598
task = ensure_future(awaitable)
598599
tasks.add(task)

tests/execution/test_defer.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -742,7 +742,6 @@ async def handles_non_nullable_errors_thrown_outside_deferred_fragments():
742742

743743
@pytest.mark.asyncio()
744744
async def handles_async_non_nullable_errors_thrown_in_deferred_fragments():
745-
return # TODO: hangs
746745
document = parse(
747746
"""
748747
query HeroNameQuery {

0 commit comments

Comments
 (0)