Skip to content

Fix validate command not logging filename with only deprecations #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix validate command not logging filename with only deprecations #2884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions packages/commands/validate/__tests__/validate-command.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const schema = buildSchema(/* GraphQL */ `
title: String
createdAt: String
modifiedAt: String
deprecatedTitle: String @deprecated(reason: "Will be deleted")
}

type Query {
Expand Down Expand Up @@ -60,6 +61,16 @@ const validate = createCommand({
`),
location: 'valid-document.graphql',
},
{
document: parse(/* GraphQL */ `
query post {
post {
deprecatedTitle
}
}
`),
location: 'with-deprecated-only.graphql',
},
];
},
},
Expand Down Expand Up @@ -116,4 +127,11 @@ describe('validate', () => {

expect(spyReporter).not.toHaveBeenCalledNormalized('document.graphql:');
});

test('should log deprecation when file has only deprecation', async () => {
await mockCommand(validate, 'validate "*.graphql" schema.graphql');

expect(spyReporter).toHaveBeenCalledNormalized('in with-deprecated-only.graphql');
expect(spyReporter).toHaveBeenCalledNormalized('The field Post.deprecatedTitle is deprecated. Will be deleted');
})
});
2 changes: 1 addition & 1 deletion packages/commands/validate/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ function printInvalidDocuments(
}

for (const doc of invalidDocuments) {
if (doc.errors.length) {
if (doc[listKey].length) {
for (const line of renderErrors(doc.source.name, doc[listKey], isError)) {
Logger.log(line);
}
Expand Down