Skip to content

feat!: Upgrade to Binaryen v117 #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat!: Upgrade to Binaryen v117 #203

wants to merge 1 commit into from

Conversation

ospencer
Copy link
Member

@ospencer ospencer self-assigned this Feb 28, 2025
@ospencer ospencer force-pushed the oscar/116 branch 2 times, most recently from 8e0018b to 70fbf32 Compare May 15, 2025 05:50
Base automatically changed from oscar/116 to master May 17, 2025 11:19
@ospencer ospencer marked this pull request as ready for review May 17, 2025 11:30
@ospencer
Copy link
Member Author

This is good to go—I'll add a note about the breaking int->string memory segment change when I merge.

@ospencer ospencer requested a review from a team May 17, 2025 11:31
spotandjake
spotandjake reviewed May 17, 2025
View reviewed changes
Copy link
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves look good to me but the tests seem to be failing on windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spotandjake spotandjake spotandjake left review comments

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ospencer @spotandjake