build(deps): update dependency com.google.cloud:google-cloud-shared-config to v1.15.1 #3724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trusted-contributions-gcf
bot
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
diegomarquezp
added
the
do not merge
|
|
diegomarquezp
removed
the
do not merge
|
Actually, #3723 is just part of the follow up. Since we don't expect releases of sdk-platform for at least 2 weeks, it's fine to merge this one in. |
|
/gcbrun |
3 tasks
|
Closed in favor of #3726, which prepares the repo for this upgrade. |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
renovate-bot
deleted the
renovate/com.google.cloud-google-cloud-shared-config-1.x
branch
diegomarquezp
added a commit
that referenced
this pull request
Apr 2, 2025
…nfig update (#3726) [Context Doc](https://docs.google.com/document/d/1Fqb4lXZ0FEpkJoSUvUp7Ow-z0fdcLyLE30lDDsGaRY0/edit?resourcekey=0-IueNnA7qMxmyWH6bGE9bsw&tab=t.0#heading=h.pi1uh78box27) This replaces #3724 in order to manually prepare the repo for this update. The preparation includes: - Update google-cloud-shared-config to `1.15.1`. - Configure pom.xml files to reference the `fmt` plugin using the `com.spotify.fmt` groupId instead of `com.coveo`. The group ID in [since 2022](https://github.com/spotify/fmt-maven-plugin/blame/main/README.md#L7). Some pom.xml explicitly referenced the `2.9.1` version, but I removed it so it's [controlled by google-cloud-shared-config](https://github.com/googleapis/java-shared-config/blob/bc8f22d02511c0467271698acf340874ed987160/java-shared-config/pom.xml#L172-L174). - Update our `ci.yaml` to either run the `mvn` tasks using java 17 or running the task with the `-Dfmt.skip` flag. - Update `java_compatibility_check.yaml` from java 11 to java 17. - Update our docker image to use java 17 instead of 11. - Format the codebase using `mvn fmt:format` (see 36d9ee4 for format changes). ### Review instructions You will see that the checks are failing because I did not include file formatting in the latest commit of this PR for the sake of browser performance. However, I ran the checks in 36d9ee4 with formatted files and they were all green except for the integration test, which is failing because I haven't updated the golden branch (see [this branch comparison](googleapis/google-cloud-java@chore/test-hermetic-build...chore/test-hermetic-build-update-sharedconfig-and-lint) for upcoming changes), which I plan to do before merging this PR. #### Before merging: - [x] Update golden branch - [x] Restore hermetic_library_generation workflow - [x] Restore formatted java files --------- Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.15.0->1.15.1Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
googleapis/java-shared-config (com.google.cloud:google-cloud-shared-config)
v1.15.1Compare Source
Dependencies
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.