-
Notifications
You must be signed in to change notification settings - Fork 65
chore(hermetic-build): include .github template updates as part of generation #3723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 11 commits
1bb6936
4a59a65
c25a14a
56c6f1c
a2effdc
364b79f
df9a033
c908f7b
755c0de
cb5a1ca
b66af92
88e6edb
b136655
b9a7d01
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
suztomo marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
externalManifests: | ||
- type: json | ||
file: 'synth.metadata' | ||
jsonpath: '$.generatedFiles[*]' | ||
- type: json | ||
file: '.github/readme/synth.metadata/synth.metadata' | ||
jsonpath: '$.generatedFiles[*]' | ||
ignoreAuthors: | ||
- 'renovate-bot' | ||
- 'yoshi-automation' | ||
- 'release-please[bot]' | ||
- 'gcf-owl-bot[bot]' |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,10 @@ | |
"owlbot/src/poms/*.py", | ||
"owlbot/templates/clirr/*.j2", | ||
"owlbot/templates/poms/*.j2", | ||
"owlbot/templates/java_library/.github/**/*", | ||
# TODO: uncomment this line after https://github.com/googleapis/sdk-platform-java/pull/3723 | ||
# has been merged. | ||
#"owlbot/templates/java_library/.kokoro/**/*", | ||
"owlbot/templates/java_library/**/*", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we still need this line? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, there are files outside |
||
], | ||
"synthtool": ["owlbot/synthtool/**/*"], | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would rerun the same command can solve the permission issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm link
has effect in the current shell session. My guess is that what's in an old session may get its permissions overriden.