-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Ajout de la traduction française (fr-FR) #2722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
👋 Hello, I just wanted to leave a quick note to mention that I had initially forgotten to sign the CLA, but that's now been done ✅ This PR adds a full French translation of the course under It looks like the checks are still pending approval before the workflows can run — no rush at all, just wanted to confirm everything is now in order on my end. Thanks again for this great resource and your time maintaining it! 🦀🇫🇷 – Simon Baeckelant |
Hi @SimonBaeckelant, bonjour! 😃 Nice to meet you and wow, thanks for all the work here! I won't be able to merge this as-is since we actually have a full translation system configured. Please see TRANSLATIONS to get started. In short, the system requires you to take each bit of French text and match it with the corresponding English text. This happens in the (outdated A first good step would be to refresh the translation. Then you and others can edit the Translating the Markdown files in this PR automatically back to a |
Hi again! 👋 I've completed the translation of Let me know if any adjustments are needed — thanks again for your guidance and for maintaining this project! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that was quick. Amazing!
Just a small request: please delete the src/translations/fr-FR/fr.po
file since it won't be used by our publishing process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this file, it won't be used by the translation infrastructure.
Hmm, the test fails here in a third-party library we use. Could you make sure to include a --- a/po/fr.po
+++ b/po/fr.po
@@ -1,16 +1,15 @@
msgid ""
msgstr ""
"Project-Id-Version: Comprehensive Rust 🦀\n"
-"POT-Creation-Date: 2024-04-05T16:37:18-04:00\n"
-"PO-Revision-Date: 2024-05-24 15:14-0400\n"
-"Last-Translator: Olivier Charrez <olivier.charrez@hotmail.com>\n"
-"Language-Team: French <traduc@traduc.org>\n"
-"Language: fr\n"
-"MIME-Version: 1.0\n"
+"POT-Creation-Date: 2025-05-08T11:23:04-04:00\n"
+"PO-Revision-Date: \n"
+"Last-Translator: Simon Baeckelant <simonbaeckelant@gmail.com>\n"
+"Language-Team: French <traduc@traduc.org>\n"
+"Language: fr\n"
+"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
-"Plural-Forms: nplurals=2; plural=(n > 1);\n"
-"X-Generator: Poedit 3.4.2\n"
+"X-Generator: Poedit 3.6\n" The problem is the missing |
A little tip for PRs like this: gh pr diff 2722 | bat -l patch make it possible to view the diff, despite it being huge. |
Hello,
This PR adds a French translation of the Comprehensive Rust course under
src/translations/fr-FR/
.All
.md
files have been translated, following the original structure, formatting, and tone.The
SUMMARY.md
file contains translated titles but keeps original file paths, as required bymdBook
.The translation uses official terminology from the Rust community (e.g., ownership, borrow checker, traits, etc.).
Thanks a lot for this amazing learning resource 🦀
I'm happy to apply any suggestions or corrections you may have!