Skip to content

builtin: Implement builtin function any, all. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2018
Merged

builtin: Implement builtin function any, all. #1

merged 1 commit into from
Aug 5, 2018

Conversation

corona10
Copy link
Collaborator

@corona10 corona10 commented Aug 4, 2018

Hi, I have highly interested in this project.
I've experienced to work on the grumpy project also.

Anyway, this might be my first PR, Please take a look.

@corona10
Copy link
Collaborator Author

corona10 commented Aug 4, 2018

It looks like there is no CI process on this project.
I hope this will be added.

@ncw
Copy link
Collaborator

ncw commented Aug 4, 2018

Thank you for your contribution :-)

I haven't set a CI up yet as I've been a bit busy, but I hope to review your PR and set up CI tomorrow.

I've very excited my first pull request for this project and pleased to hear that you are interested in the project :-)

@corona10
Copy link
Collaborator Author

corona10 commented Aug 5, 2018

@ncw Yeah great! Let s implement features of Python 3.4 until late 2018 :)

@ncw ncw merged commit 8a7aec9 into go-python:master Aug 5, 2018
@ncw
Copy link
Collaborator

ncw commented Aug 5, 2018

I gave that a read through and it looks fine so I've merged it :-)

I've set up CI for the project (fairly basic to start with). I'd like to put some code quality tools in eventualy too errcheck/lint/etc

I'd like to integrate py3test.py into the CI too to make sure that the tests work with python3 also....

If you'd like to be a maintainer for this project, then drop me an email to nick@craig-wood.com and we can have a chat about it!

@sbinet
Copy link
Member

sbinet commented Aug 5, 2018

Would you be willing to migrate this project to the go-python organization?
We don't have much more peoplepower, but we could have a bit of turnover...

@corona10 corona10 deleted the builtin_any_all branch August 5, 2018 15:44
@ncw
Copy link
Collaborator

ncw commented Aug 6, 2018

@sbinet can you drop me an email to nick@craig-wood.com and we can discuss - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants