Replace autofocus with data-global-init="initInputAutoFocusEnd".

[kerwin612]

before:

after:

[wxiaoguang]

For most pages, the "autofocus" or "initInputAutoFocusEnd" seems abused.

I would suggest either leave autofocus as-is, or just remove it, but don't make it more complex than it should be.

[kerwin612]

For most pages, the "autofocus" or "initInputAutoFocusEnd" seems abused.

I would suggest either leave autofocus as-is, or just remove it, but don't make it more complex than it should be.

My viewpoints are as follows:
① First of all, when there are input elements on the page, the user experience will be better if the first input element can be automatically focused on.
② Secondly, when the value of the input element is not empty, the user experience will also be better if the cursor is automatically focused after the last character.
I believe that a good user experience can only be achieved when both of the above points are met. If we simply focus without considering the situation where the value is not empty, it will lead to a poor user experience.

As I'm writing this, I'm thinking about whether we can add a utility function in the Go code:

• Go

func inputAttrs(value string) string {
    if value != "" {
        return "data-global-init=\"initInputAutoFocusEnd\""
    }
    return "autofocus"
}

• Template

<input {{inputAttrs value}}/>

This is just a preliminary idea. My point is that we should either not implement autofocus at all or implement it properly. We can't do a half - baked job.

[wxiaoguang]

① First of all, when there are input elements on the page, the user experience will be better if the first input element can be automatically focused on.

Why they should be focused? Does end user would really like to input anything in most cases? Take GitHub as an example, most input doesn't get "autofocus" on most pages.

[wxiaoguang]

Don't you see some changes are wrong?

What's the difference between normal auto-focus and focus-cursor-end for URL and Token inputs? Why end users would to "append" anything to that inputs?

[wxiaoguang]

Don't make changes which you don't understand.

[kerwin612]

Why they should be focused? Does end user would really like to input anything in most cases? Take GitHub as an example, most input doesn't get "autofocus" on most pages.

Yes, so my view is that if the autofocus is unnecessary, we should remove it. If autofocus is necessary, I suggest we optimize it properly, just as per the solution I mentioned above.

[wxiaoguang]

Why you assume that when a user goes to the "settings profile" page, they are highly likely going to change their username?

If they don't want to change their username, why the input should be auto-focused?

[kerwin612]

The starting point is as follows:
I was about to edit my username. When I came to this page, the input box for the username had already gained focus because the autofocus attribute was added to the input element.
Then:
① I had to click at the end of the input box, press the Backspace key to delete the original username, and then enter a new one.
② Or, I could press the Delete key to delete the original username and then enter a new one.
At least in my opinion, ordinary people use the Backspace key far more frequently than the Delete key. So I thought it was unreasonable, and that's why I naturally submitted this PR.

[wxiaoguang]

I have no interest to do more arguments.

In short: GitHub doesn't do so, Discord doesn't do so, I guess GitLab doesn't do so either.

I do not see any website do so.

[kerwin612]

[wxiaoguang]

1. It is NOT username
2. It is NOT autofocus or initInputAutoFocusEnd. They WILL NOT WORK because the element is hidden when the page loads.

[wxiaoguang]

The screenshot of GitHub is RIGHT because when a user clicks "Edit Profile", they ARE HIGHLY LIKELY going to edit their "display" name, and that focus helps to make the newly shown "edit profile form" focused. That's different from a NORMAL page.

But as I said above: Gitea's most "autofocus" usages are abuses.

Why you assume that when a user goes to the "settings profile" page, they are highly likely going to change their username?

[kerwin612]

I reverted all the other modifications and only kept the changes on the page shown in my screenshot.