make-file-list: include the new /etc/msystem.d/ folder #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of filesystem-2025.05.08-1, the various definitions depending on the environment variable `MSYSTEM` are no longer in a single `/etc/msystem` file, but rather in files in the new `/etc/msystem.d/` directory whose filenames reflect the value of said environment variable. As per the suggestion in git-for-windows/git-sdk-64#99 (comment), let's include this directory in the payload of Git for Windows' installer so that users are not greeted with the message: bash: /etc/msystem.d/MSYS: No such file or directory Suggested-by: Jeremy Drake <github@jdrake.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
I will need to merge this PR quickly because -rc1 is scheduled for today and I haven't managed to get -rc0 out yet. |
mjcheetham
approved these changes
Jun 3, 2025
rimrul
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of filesystem-2025.05.08-1, the various definitions depending on the environment variable
MSYSTEMare no longer in a single/etc/msystemfile, but rather in files in the new/etc/msystem.d/directory whose filenames reflect the value of said environment variable.As suggested, let's include this directory in the payload of Git for Windows' installer so that users are not greeted with the message: