Delegate PEC check from MultiPhysicsMedium to its Optical Medium #2431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
momchil-flex
reviewed
May 7, 2025
frederikschubertflex
force-pushed
the
frederikschubertflex/fix-plot_structures_property-with-MultiPhysicsMedium
branch
from
6ab39a4 to
9a5cd84
Compare
momchil-flex
reviewed
May 9, 2025
…property-with-MultiPhysicsMedium
daquinteroflex
approved these changes
May 12, 2025
…property-with-MultiPhysicsMedium
daquinteroflex
deleted the
frederikschubertflex/fix-plot_structures_property-with-MultiPhysicsMedium
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check is used for plotting the permittivity in the https://github.com/flexcompute/tidy3d/blame/9c8ca5ff9310a681352ae0c2624c9a142275cd6f/tidy3d/components/scene.py#L1040C9-L1040C20
_eps_boundsmethod. I am not sure whether this should depend solely on the optical medium or if the other media are relevant as well.Fixes https://github.com/flexcompute/tidy3d-core/issues/956