fix[autograd]: remove frequency summing in CustomMedium gradient and … #2430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actually, there are a few other problematic spots in the medium file where we sum over frequency that need fixing. |
groberts-flex
force-pushed
the
groberts-flex/debug_autograd_wdm
branch
2 times, most recently
from
44f42a2 to
09b3488
Compare
|
going to fix this in a slightly different given the multiple other cases that came up, will update when I have that done! |
groberts-flex
force-pushed
the
groberts-flex/debug_autograd_wdm
branch
2 times, most recently
from
d602448 to
b106971
Compare
|
alright, rebased and cleaned a couple of things up, think this is ready for review now |
yaugenst-flex
requested changes
May 8, 2025
There was a problem hiding this comment.
Thanks @groberts-flex for fixing this! Looks great, only some minor comments.
groberts-flex
force-pushed
the
groberts-flex/debug_autograd_wdm
branch
from
b106971 to
a5e3c09
Compare
…select adjoint frequency
groberts-flex
force-pushed
the
groberts-flex/debug_autograd_wdm
branch
from
a5e3c09 to
14cb927
Compare
yaugenst-flex
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a recent update for structure derivative computation, we now need to now sum over frequency in CustomMedium gradient computation because we are computing one frequency at a time (the iteration happens over frequency in autograd.py now).