Add support for 2D EME simulations #2410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EME should support 2D simulations for consistency with FDTD and mode simulations.
To that end, this PR:
boundaries_for_zero_dims
validator fromSimulation
toEMESimulation
andModeSimulation
This doesn't break backwards compatibility for EME simulations. It does break backwards compatibility for mode simulations, but those have not yet been "officially released" anyway. Specifically, if you try to create a 2D FDTD simulation and run the mode solver on a 1D cross-section, the FDTD simulation will fail validation if the boundary condition is PEC and not periodic in the 0-thickness direction. However, if you tried to create a mode simulation with the PEC boundary condition (a rather unlikely thing to do as the default is PML), it would previously have passed validation and then been converted to periodic boundary internally in
subsection
. Now, it will fail validation, consistently with the other setup.