Skip to content

Add support for 2D EME simulations #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

Add support for 2D EME simulations #2410

merged 1 commit into from
May 8, 2025

Conversation

caseyflex
Copy link
Contributor

@caseyflex caseyflex commented Apr 25, 2025

EME should support 2D simulations for consistency with FDTD and mode simulations.

To that end, this PR:

  • Makes the mode planes in an EME simulation infinite; the mode solving still occurs in the intersection with the simulation geometry
  • Allows EME simulations to have non-PEC boundary conditions. In general this can allow for more consistency with FDTD and mode simulations. The specific use case here though is periodic boundary conditions on size 0 dimensions.
  • Adds the boundaries_for_zero_dims validator from Simulation to EMESimulation and ModeSimulation
  • Keeps the default boundary as PEC for EME simulations and PML for mode simulations

This doesn't break backwards compatibility for EME simulations. It does break backwards compatibility for mode simulations, but those have not yet been "officially released" anyway. Specifically, if you try to create a 2D FDTD simulation and run the mode solver on a 1D cross-section, the FDTD simulation will fail validation if the boundary condition is PEC and not periodic in the 0-thickness direction. However, if you tried to create a mode simulation with the PEC boundary condition (a rather unlikely thing to do as the default is PML), it would previously have passed validation and then been converted to periodic boundary internally in subsection. Now, it will fail validation, consistently with the other setup.

@caseyflex
Copy link
Contributor Author

@tylerflex FYI, we will be able to support 2D EME simulations after this (requires new solver version though)

@tylerflex
Copy link
Collaborator

Yay! Thanks @caseyflex

Copy link
Collaborator

@yaugenst-flex yaugenst-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @caseyflex!

@caseyflex caseyflex enabled auto-merge (rebase) May 8, 2025 16:17
@caseyflex caseyflex merged commit 629fc8b into develop May 8, 2025
9 checks passed
@caseyflex caseyflex deleted the casey/eme2d branch May 8, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants