Skip to content

Change threshold for number of frequencies in EME for warning #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025
Merged

Change threshold for number of frequencies in EME for warning #2402

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
503d7f6
Change threshold for number of frequencies in EME for warning
caseyflex Apr 23, 2025
0eb45af
Merge branch 'develop' into casey/emewarning
momchil-flex May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- Performance enhancement for adjoint gradient calculations by optimizing field interpolation.
- Auto grid in EME simulations with multiple `freqs` provided uses the largest instead of raising an error.
- Increased maximum number of frequencies in an EME simulation from 20 to 500. Still warns if more than 20 frequencies are used, as this may lead to slower or more expensive simulations.

### Fixed
- Fixed `reverse` property of `td.Scene.plot_structures_property()` to also reverse the colorbar.
Expand Down
2 changes: 1 addition & 1 deletion tidy3d/components/eme/simulation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@


# eme specific simulation parameters
WARN_NUM_FREQS = 100
WARN_NUM_FREQS = 20
MAX_NUM_FREQS = 500
MAX_NUM_SWEEP = 100

Expand Down