Skip to content

Clarify fit behavior #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2025
Merged

Conversation

dongle-the-gadget
Copy link
Contributor

Description

The current explanation makes sense for XAML developers, but not so much for regular users.

Motivation and Context

Provide clarity on the behavior of different image fit settings.

Screenshots (if appropriate):

N/A

The current explanation makes sense for XAML developers, but not so much for regular users.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful to retain the XAML style behaviour here alongside the prettier documentation
e.g.: Fill: The image is stretched...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is of much use.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit db4369d into files-community:main May 11, 2025
@yaira2 yaira2 added the approved This pull request is approved label May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This pull request is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants