Skip to content

2024-07-29 v. 6.3.3.1: updated TreeNode equals method #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024
Merged

2024-07-29 v. 6.3.3.1: updated TreeNode equals method #692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions lib/common/binary_tree.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,10 @@ def initialize(val = 0, left = nil, right = nil)
@right = right
end

# @param {TreeNode} other
# @return {Boolean}
def ==(other)
are_equals(self, other)
end

private

# @param {TreeNode} curr
# @param {TreeNode} other
# @return {Boolean}
def are_equals(curr, other)
def self.are_equals(curr, other)
return true if curr.nil? && other.nil?
return false if curr.nil? || other.nil?

Expand Down
21 changes: 18 additions & 3 deletions test/common/test_binary_tree.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,29 @@ def test_default
::TreeNode.new(2),
::TreeNode.new(3)
)
assert_equal(first, second)
assert(
::TreeNode.are_equals(
first,
second
)
)

third = ::TreeNode.new(
1,
::TreeNode.new(4),
::TreeNode.new(5)
)
assert(first != third)
assert(second != third)
assert(
!::TreeNode.are_equals(
first,
third
)
)
assert(
!::TreeNode.are_equals(
second,
third
)
)
end
end
44 changes: 24 additions & 20 deletions test/easy/test_108_convert_sorted_array_to_binary_search_tree.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,31 +7,35 @@

class ConvertSortedArrayToBinarySearchTreeTest < ::Minitest::Test
def test_default
assert_equal(
::TreeNode.new(
0,
assert(
::TreeNode.are_equals(
::TreeNode.new(
-10,
nil,
::TreeNode.new(-3)
0,
::TreeNode.new(
-10,
nil,
::TreeNode.new(-3)
),
::TreeNode.new(
5,
nil,
::TreeNode.new(9)
)
),
::TreeNode.new(
5,
nil,
::TreeNode.new(9)
sorted_array_to_bst(
[-10, -3, 0, 5, 9]
)
),
sorted_array_to_bst(
[-10, -3, 0, 5, 9]
)
)
assert_equal(
::TreeNode.new(
1,
nil,
::TreeNode.new(3)
),
sorted_array_to_bst([1, 3])
assert(
::TreeNode.are_equals(
::TreeNode.new(
1,
nil,
::TreeNode.new(3)
),
sorted_array_to_bst([1, 3])
)
)
end
end
12 changes: 10 additions & 2 deletions test/easy/test_144_binary_tree_preorder_traversal.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,15 @@ def test_default
)
)
)
assert_equal([], preorder_traversal(nil))
assert_equal([1], preorder_traversal(::TreeNode.new(1)))
assert_equal(
[],
preorder_traversal(nil)
)
assert_equal(
[1],
preorder_traversal(
::TreeNode.new(1)
)
)
end
end
64 changes: 34 additions & 30 deletions test/easy/test_226_invert_binary_tree.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,47 +7,51 @@

class InvertBinaryTreeTest < ::Minitest::Test
def test_default
assert_equal(
::TreeNode.new(
4,
::TreeNode.new(
7,
::TreeNode.new(9),
::TreeNode.new(6)
),
::TreeNode.new(
2,
::TreeNode.new(3),
::TreeNode.new(1)
)
),
invert_tree(
assert(
::TreeNode.are_equals(
::TreeNode.new(
4,
::TreeNode.new(
2,
::TreeNode.new(1),
::TreeNode.new(3)
7,
::TreeNode.new(9),
::TreeNode.new(6)
),
::TreeNode.new(
7,
::TreeNode.new(6),
::TreeNode.new(9)
2,
::TreeNode.new(3),
::TreeNode.new(1)
)
),
invert_tree(
::TreeNode.new(
4,
::TreeNode.new(
2,
::TreeNode.new(1),
::TreeNode.new(3)
),
::TreeNode.new(
7,
::TreeNode.new(6),
::TreeNode.new(9)
)
)
)
)
)
assert_equal(
::TreeNode.new(
2,
::TreeNode.new(1),
::TreeNode.new(3)
),
invert_tree(
assert(
::TreeNode.are_equals(
::TreeNode.new(
2,
::TreeNode.new(3),
::TreeNode.new(1)
::TreeNode.new(1),
::TreeNode.new(3)
),
invert_tree(
::TreeNode.new(
2,
::TreeNode.new(3),
::TreeNode.new(1)
)
)
)
)
Expand Down
74 changes: 39 additions & 35 deletions test/easy/test_617_merge_two_binary_trees.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,57 +7,61 @@

class MergeTwoBinaryTreesTest < ::Minitest::Test
def test_default
assert_equal(
::TreeNode.new(
3,
assert(
::TreeNode.are_equals(
::TreeNode.new(
4,
::TreeNode.new(5),
::TreeNode.new(4)
),
::TreeNode.new(
5,
nil,
::TreeNode.new(7)
)
),
merge_trees(
::TreeNode.new(
1,
3,
::TreeNode.new(
3,
4,
::TreeNode.new(5),
nil
::TreeNode.new(4)
),
::TreeNode.new(2)
::TreeNode.new(
5,
nil,
::TreeNode.new(7)
)
),
::TreeNode.new(
2,
merge_trees(
::TreeNode.new(
1,
nil,
::TreeNode.new(4)
::TreeNode.new(
3,
::TreeNode.new(5),
nil
),
::TreeNode.new(2)
),
::TreeNode.new(
3,
nil,
::TreeNode.new(7)
2,
::TreeNode.new(
1,
nil,
::TreeNode.new(4)
),
::TreeNode.new(
3,
nil,
::TreeNode.new(7)
)
)
)
)
)
assert_equal(
::TreeNode.new(
2,
::TreeNode.new(2),
nil
),
merge_trees(
::TreeNode.new(1),
assert(
::TreeNode.are_equals(
::TreeNode.new(
1,
2,
::TreeNode.new(2),
nil
),
merge_trees(
::TreeNode.new(1),
::TreeNode.new(
1,
::TreeNode.new(2),
nil
)
)
)
)
Expand Down
30 changes: 16 additions & 14 deletions test/easy/test_700_search_in_a_binary_search_tree.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,25 @@

class SearchInABinarySearchTreeTest < ::Minitest::Test
def test_default
assert_equal(
::TreeNode.new(
2,
::TreeNode.new(1),
::TreeNode.new(3)
),
search_bst(
assert(
::TreeNode.are_equals(
::TreeNode.new(
4,
2,
::TreeNode.new(1),
::TreeNode.new(3)
),
search_bst(
::TreeNode.new(
2,
::TreeNode.new(1),
::TreeNode.new(3)
4,
::TreeNode.new(
2,
::TreeNode.new(1),
::TreeNode.new(3)
),
::TreeNode.new(7)
),
::TreeNode.new(7)
),
2
2
)
)
)
assert_nil(
Expand Down
Loading
Loading