Skip to content

complex-numbers: sync #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

rabestro
Copy link
Member

@rabestro rabestro commented Apr 25, 2025

Sync the complex-numbers exercise with the latest data, as defined in https://github.com/exercism/problem-specifications/tree/main/exercises/complex-numbers.

Expanded the instructions for complex number operations by providing detailed explanations and examples for addition, subtraction, multiplication, division, conjugate, absolute value, and exponentiation. Clarified implementation requirements and emphasized the use of manual calculations without built-in library support.
Copy link

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

@rabestro rabestro changed the title comple-numbers: sync complex-numbers: sync Apr 25, 2025
@BNAndras
Copy link
Member

These changes are pretty thorough. Perhaps this would be a better fit for the upstream problem-specifications repo? Directly editing instructions.md runs the risk of maintainers overwriting your changes when they sync from that repo.

@rabestro
Copy link
Member Author

These changes are pretty thorough. Perhaps this would be a better fit for the upstream problem-specifications repo? Directly editing instructions.md runs the risk of maintainers overwriting your changes when they sync from that repo.

These changes are already in the problem-specifications repository. The current track for the Scala language is outdated. I don't know if there is a utility that centrally synchronizes all the descriptions in the Scala track to the latest version that are in the problem-specifications repository.

Outdated description in the Scala track:
https://github.com/exercism/scala/blob/main/exercises/practice/complex-numbers/.docs/instructions.md

Current description in problem-specifications repository:
https://github.com/exercism/problem-specifications/blob/main/exercises/complex-numbers/description.md

I updated one exercise description. It was outdated. I don't know how to update all similar files at once.

@BNAndras
Copy link
Member

https://exercism.org/docs/building/configlet/sync configlet sync will sync metadata, tests, and documents for you. You’ll still need to implement any added tests (not sure if this track uses a generator for that). Generally I sync tests separately from the metadata and documents, one exercise at a time. That makes PR review easier.

Added spacing for better readability in the list describing complex number components. This enhances the clarity of the instructions for users.
@rabestro
Copy link
Member Author

https://exercism.org/docs/building/configlet/sync configlet sync will sync metadata, tests, and documents for you. You’ll still need to implement any added tests (not sure if this track uses a generator for that). Generally I sync tests separately from the metadata and documents, one exercise at a time. That makes PR review easier.

I confirm that this pull request was made by command:

 ./bin/configlet sync --exercise complex-numbers --update --docs
Updating cached 'problem-specifications' data...
Checking exercises...
[warn] docs: instructions unsynced: complex-numbers
sync the above docs ([y]es/[n]o)? y
Updated the docs for 1 Practice Exercise
The `complex-numbers` exercise has up-to-date docs!

@rabestro
Copy link
Member Author

https://exercism.org/docs/building/configlet/sync configlet sync will sync metadata, tests, and documents for you. You’ll still need to implement any added tests (not sure if this track uses a generator for that). Generally I sync tests separately from the metadata and documents, one exercise at a time. That makes PR review easier.

I close this pull request in favour of a full sync for the whole Scala track
#856

@rabestro rabestro closed this Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants