SimpleUI: support target's tags edition, display installed & assigned distribution sets, and action history #2409
Conversation
|
Can one of the admins verify this patch? |
|
switching to draft as I'm adding Actions history tab; this way this PR will contain all intended features rather than part of it :) |
zeapo
force-pushed
the
feature/actions-history
branch
from
9400950 to
4e8bc96
Compare
This is inspired by the original hawkbit interface; however, as we've got more space it merges both Assigned and Installed into the same tab
zeapo
force-pushed
the
feature/actions-history
branch
3 times, most recently
from
f68ea6b to
e27a569
Compare
This allows tracking the actions, see their status, and cancel / force / force cancel them; just like the previous ui This has some limitations though; the previous UI had access to the Action's main class, whereas we're dealing with the rest dto; hence we're missing some information to make the ui simpler to create.
zeapo
force-pushed
the
feature/actions-history
branch
from
e27a569 to
c33efe5
Compare
zeapo
changed the title
|
@strailov dunno if you want me to split this into two PR, one to fix the flaky OAuth2TokenManager and the rest as UI features? |
|
@zeapo great work you are doing with the SimpleUI lately. |
|
Thank you @maass-hamburg 😊 |
|
Hello @zeapo. Sorry I missed this. Will check this PR asap :) |
|
Thanks, just le me know if you need further improvements. I'll be working on another subject and be back to this once Spring Boot 3.5 is merged. |
hawkbit-simple-ui/src/main/java/org/eclipse/hawkbit/ui/simple/view/TargetView.java
Show resolved
Hide resolved
| if (isActive()) { | ||
| icon = new SpinnerIcon(); | ||
| } else { | ||
| icon = VaadinIcon.CHECK_CIRCLE.create(); |
There was a problem hiding this comment.
Would this also mean that if the action is in ERROR state still the CHECK_CIRCLE will be present? It is quite confusing this with the Status column in the grid. I would unify this Active column with the Status in the target grid maybe, what do you think ? Like when it is pending there is a yellow half full circle
There was a problem hiding this comment.
Absolutely, I struggled to get a clear separation of the status / type concepts;
I wanted to keep a sort of similarity with the previous UI
I'll try to merge them and see how it ends up 👍🏼
There was a problem hiding this comment.
Just updated it; here are the four cases, half_circle + orange is pending as target status; half_circle + red is canceling ; the others are the same
There was a problem hiding this comment.
PS: also extracted the force quit so that it's cleaner as it was confusing close to the other two actions
hawkbit-simple-ui/src/main/java/org/eclipse/hawkbit/ui/simple/view/TargetView.java
Outdated
Show resolved
Hide resolved
hawkbit-simple-ui/src/main/java/org/eclipse/hawkbit/ui/simple/view/TargetView.java
Outdated
Show resolved
Hide resolved
|
FYI, a4e4ea9 |
|
Contains a lot of UI improvement and a fix to a flaky behavior;
After multiple deployements to our test environment, we noticed that sometimes the OAuth2TokenManager is not initalized all the time; by making it conditioned on the same property as the customizer, it's always there and working fine.
Details view transformed into tabs
Display the installed and assigned distribution sets
Add tags listing; assigning, unassigning, and creation
I didn't add tag deletion of tags, it will need a new modal to list & manage existing tags.