feat(queries): add multi-line queries support #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features some refactoring to support this feature, to remove the dependency of compiling a complex reg-exp I preferred keeping the output of the findQueries function untransformed, so we can use that string to find and replace the query with the serialized query. It adds a boolean to check if we are capturing a multi-line query or not, and some logic to complete the feature. I've tested both multi-line and single-line queries to ensure that I did not break basic functionality.
Reflects some of the changes on the refactoring done, as well as simply demonstrating an example of a multi-line query.
Plumbs the code a bit to avoid duplicate queries detection issues. I was encountering duplicate serialized queries, so I am trying this method to make it more robust, the hash is done on the trimmed version of the query. I have not encountered issues since this change.
Everytime I would update a document that has the Dataview serialization queries, it would insert an additional newline at the end of the serialization. If you do the modification several times, the document would create a lot of useless newlines, so I just suggest to remove it and keep the document clean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #12
Features some refactoring to support this feature, to remove the
dependency of compiling a complex reg-exp I preferred keeping the
output of the findQueries function untransformed, so we can use that
string to find and replace the query with the serialized query.
It adds a boolean to check if we are capturing a multi-line query or not, and
some logic to complete the feature.
I've tested both multi-line and single-line queries to ensure that I did
not break basic functionality.
As a new user I would appreciate further regression tests if there are some to fix.