-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Follow-up: Improve stopping renderer, fix identity template #61633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/backport to release/10.0-preview4 |
Started backporting to release/10.0-preview4: https://github.com/dotnet/aspnetcore/actions/runs/14759993828 |
@lewing backporting to "release/10.0-preview4" failed, the patch most likely resulted in conflicts:
Please backport manually! |
@MackinnonBuck, the feedback on how to proceed in case of no data for rendering page after exception removal from #61795 (comment) is relevant also for this PR. The backport PR isn't considered for servicing currently but this one could fix the situation on main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also curious about what the strategy is around existing apps that were built with the old template. Do we expect every customer to set the AppContext
switch upon upgrading to .NET 10?
src/Components/Endpoints/src/DependencyInjection/HttpNavigationManager.cs
Outdated
Show resolved
Hide resolved
...ntent/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/ChangePassword.razor
Outdated
Show resolved
Hide resolved
...t/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Account/Pages/Manage/DeletePersonalData.razor
Outdated
Show resolved
Hide resolved
We rather prefer them to remove the exception and [DoNotReturn] manually. We added this suggestion to the release notes. |
Follow up for #61306 and #60970.
Feedback
NotFoundPage
toRouter
#60970.Templates
-auth Individual
) were expectingNavigateTo
to throw. We should remove this expectation for the new way of navigation.Framework
SignalRendererToFinishRendering
public API proposal.Testing
RenderBatchQueuedAfterRedirectionIsNotProcessed
makes sure that no renders connected with async child component are done when the parent triggered redirection in prerendering. Because more than one render mode is tested, I found it useful to reuse the code fromInteractiveStreamingRenderingComponent.razor
for getting available render modes. The common bits got moved toRenderModeHelper.cs
.CanRedirectDuringPrerendering
was removed - its expected behavior changed and the tested scenario overlaps with these covered byRenderBatchQueuedAfterRedirectionIsNotProcessed
.