Allow to paginate $search aggregation with searchBefore and searchAfter markers
#2764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
May 6, 2025
Comment on lines
1317
to
1333
| #[DataProvider('provideAutocompleteBuilders')] | ||
| #[DataProvider('provideCompoundBuilders')] | ||
| #[DataProvider('provideEmbeddedDocumentBuilders')] | ||
| #[DataProvider('provideEmbeddedDocumentCompoundBuilders')] | ||
| #[DataProvider('provideEqualsBuilders')] | ||
| #[DataProvider('provideExistsBuilders')] | ||
| #[DataProvider('provideGeoShapeBuilders')] | ||
| #[DataProvider('provideGeoWithinBuilders')] | ||
| #[DataProvider('provideMoreLikeThisBuilders')] | ||
| #[DataProvider('provideNearBuilders')] | ||
| #[DataProvider('providePhraseBuilders')] | ||
| #[DataProvider('provideQueryStringBuilders')] | ||
| #[DataProvider('provideRangeBuilders')] | ||
| #[DataProvider('provideRegexBuilders')] | ||
| #[DataProvider('provideTextBuilders')] | ||
| #[DataProvider('provideWildcardBuilders')] | ||
| public function testSearchOperatorsWithSearchBefore(array $expectedOperator, Closure $createOperator): void |
There was a problem hiding this comment.
I think a single case is sufficient to test this feature. As it is, you're simply repeating the same test many times over for no purpose.
There was a problem hiding this comment.
Thanks for the advice. I leave only one data provider on each method
GromNaN
changed the title
$search aggregation with searchBefore and searchAfter markers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feat: allow to paginate search aggregation with searchBefore and searchAfter markers