fix: tests import exception from correct location #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djudjuu
changed the title
rudolfix
approved these changes
May 6, 2025
| @@ -26,7 +26,7 @@ | |||
| from dlt.common.schema.typing import TTableSchema | |||
| from dlt.common.utils import set_working_dir | |||
|
|
|||
| from dlt.pipeline.exceptions import SqlClientNotAvailable | |||
| from dlt.common.destination.exceptions import SqlClientNotAvailable | |||
There was a problem hiding this comment.
this is ok because this is a part of tests! just remember that we need to be backward compatible with old dlt versions in the main code so you'd need to try both options there
|
what can I do to make that pass? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests did no longer run because they were trying to import this exception from a wrong location.
after moving it, most passed except the workflow
tests dlt init compatibility.with refactors iceberg and duckdb cache support
the exception imported in the utils file moved.
most workflows worked correctly, except the one in
init.ymlwhich didn't do make dev but only installeddltpure-dep-groupI dont understand why this didnt pick up the latest then, but apparrenlty it didnt. changing it to 1.10. works though