Help text for foundation Meeting model fields #1945
Conversation
|
Hi and thanks for opening this PR! 🎸 I've tagged our current secretary as a reviewer to get an opinion on the wording since those changes are mostly for their benefit I believe. Note also that the automated tests are currently failing, it seems it's because you didn't include the missing migration files for the |
|
The wording seems alright to me. One thing, I'm not too sure if https://www.djangoproject.com/styleguide/content/ is kept up to date, but Thibaud seemed to think it was good enough so it's probably better than nothing. I'll defer to others but I'm also not sure how we feel about having style elements in HTML (if we hope to use CSP some day) or having colours without using CSS variables. |
| .meeting-warning { | ||
| background: #fff3cd; | ||
| border: 2px solid #ffeeba; | ||
| border-radius: 4px; | ||
| color: #856404; | ||
| margin: 1em 0; | ||
| padding: 1em; | ||
| font-size: 1.1em; | ||
| font-weight: 500; | ||
| } | ||
| .meeting-warning::before { | ||
| content: "⚠️ "; | ||
| } |
There was a problem hiding this comment.
Could we have this in the dedicated style folder instead? or this will not work?
There was a problem hiding this comment.
That will not work because I am overriding the admin template form.For it to work, I think I will have to add compiled SCSS to the base admin template. That may break other styles as well because now, SCSS is compiled to one big output.css file.
| background: #fff3cd; | ||
| border: 2px solid #ffeeba; |
There was a problem hiding this comment.
How does it render in light theme?
fixes #1464
