davidmyersdev · davidmyersdev · Dec 23, 2023 · Dec 23, 2023 · Dec 23, 2023 · Feb 8, 2024
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -29,7 +29,8 @@ jobs:
       - uses: ./.github/actions/install-dependencies
       - run: pnpm build:core
       - run: pnpm build:shims
-      - run: pnpm -r test
+      - run: pnpm test:unit
+      - run: pnpm test:build
   typecheck:
     runs-on: ubuntu-latest
     steps:

diff --git a/README.md b/README.md
@@ -69,7 +69,9 @@ export default defineConfig({
       // Override the default polyfills for specific modules.
       overrides: {
         // Since `fs` is not supported in browsers, we can use the `memfs` package to polyfill it.
-        fs: 'memfs',
+        'fs': 'memfs',
+        // Subpaths can be specified as well.
+        'path/posix': 'path-browserify',
       },
       // Whether to polyfill `node:` protocol imports.
       protocolImports: true,

diff --git a/examples/solid/index.html b/examples/solid/index.html
@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html lang="en">
+  <head>
+    <meta charset="UTF-8" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+    <title>Example (Solid)</title>
+  </head>
+  <body>
+    <div id="solid-app"></div>
+    <script type="module" src="/src/main.ts"></script>
+  </body>
+</html>
diff --git a/examples/solid/package.json b/examples/solid/package.json
@@ -0,0 +1,17 @@
+{
+  "type": "module",
+  "private": true,
+  "scripts": {
+    "dev": "vite",
+    "build": "vite build",
+    "preview": "vite preview"
+  },
+  "dependencies": {
+    "solid-js": "^1.8.7"
+  },
+  "devDependencies": {
+    "vite": "^5.0.2",
+    "vite-plugin-node-polyfills": "workspace:*",
+    "vite-plugin-solid": "^2.8.0"
+  }
+}
diff --git a/examples/solid/src/main.ts b/examples/solid/src/main.ts
@@ -0,0 +1,4 @@
+// eslint-disable-next-line unicorn/prefer-node-protocol
+import { join } from 'path/posix'
+
+document.querySelector('#solid-app')!.textContent = join('foo', 'bar')
diff --git a/examples/solid/vite.config.ts b/examples/solid/vite.config.ts
@@ -0,0 +1,18 @@
+import { defineConfig } from 'vite'
+import { nodePolyfills } from 'vite-plugin-node-polyfills'
+import solid from 'vite-plugin-solid'
+
+export default defineConfig({
+  optimizeDeps: {
+    force: true,
+  },
+  plugins: [
+    nodePolyfills({
+      overrides: {
+        'path/posix': 'path-browserify',
+      },
+    }),
+    // comment/uncomment it:
+    solid(),
+  ],
+})
diff --git a/examples/vue/vite.config.ts b/examples/vue/vite.config.ts
@@ -4,6 +4,14 @@ import { nodePolyfills } from 'vite-plugin-node-polyfills'
 
 // https://vitejs.dev/config/
 export default defineConfig({
+  build: {
+    lib: {
+      entry: './src/main.ts',
+      fileName: 'index',
+      formats: ['es', 'cjs'],
+    },
+    minify: false,
+  },
   plugins: [
     nodePolyfills(),
     vue(),

diff --git a/package.json b/package.json
@@ -76,9 +76,11 @@
     "test": "run-p test:build test:error-repros test:unit",
     "test:build": "run-p test:build:*",
     "test:build:react": "pnpm -C ./examples/react run build",
+    "test:build:solid": "pnpm -C ./examples/solid run build",
     "test:build:vanilla": "pnpm -C ./examples/vanilla run build",
     "test:build:vue": "pnpm -C ./examples/vue run build",
     "test:dev:react": "pnpm -C ./examples/react run dev",
+    "test:dev:solid": "pnpm -C ./examples/solid run dev",
     "test:dev:vanilla": "pnpm -C ./examples/vanilla run dev",
     "test:dev:vue": "pnpm -C ./examples/vue run dev",
     "test:error-repros": "run-p test:error-repros:*",
@@ -95,10 +97,14 @@
   },
   "dependencies": {
     "@rollup/plugin-inject": "^5.0.5",
-    "node-stdlib-browser": "^1.2.0"
+    "browser-resolve": "^2.0.0",
+    "node-stdlib-browser": "^1.2.0",
+    "pkg-dir": "^8.0.0",
+    "resolve-esm": "^2.0.3"
   },
   "devDependencies": {
     "@playwright/test": "^1.40.1",
+    "@types/browser-resolve": "^2.0.4",
     "@types/node": "^18.18.8",
     "buffer": "6.0.3",
     "esbuild": "^0.19.8",