Skip to content

Added subquery logic (Not fully) #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Added subquery logic (Not fully) #7

wants to merge 15 commits into from

Conversation

nikhil3303
Copy link

No description provided.

Nikhil Kameshwaran and others added 11 commits August 26, 2024 12:46
Handling subqueries fixed
fe0dcb1
Handling subqueries fixed (typo error)
0e44648
@nikhil3303
cte_subquery_ and cte_recursive fixex
cfc4ba7
@nikhil3303
typo fixed in recursive CTE test case
1aabcec
Initial commit message for added testcases
37c6b17
@nikhil3303
Fixed wrong import statement in test_sql_query_filter.py
2bf2452 
Original - "from dataneuron.core.sql_query_filter import SQLQueryFilter" changed to "from sql_query_filter import SQLQueryFilter" for testing purposes but forgot to change it back before commit
Logic added for handing additional subquery cases - only the detectio…
1a994fb 
…n method is added not the handling method
Logic for GROUPBY, HAVING, ORDERBY added (only to contains_subquery m…
5122450 
…ethod and not the handle_subquery method
_handle_set_operations method is now able to handle cases where the S…
7c3d38d 
…ELECT statements are enclosed in parenthesis
@nikhil3303
Previous test cases work without throwing errors, CTE now compatible …
ee2585f 
…with the new logic, Added separate python files for detecting and handling subqueries - Detection logic not working for FROM subqueries(Detection logic to be modified) - end_keywords subquery detection and handling removed for now, Removed dead functions
@nikhil3303
_apply_filter_to_single_CTE_query method was accidently removed in la…
11edff7 
…st commit - added back
@nikhil3303
Copy link
Author

nikhil3303 commented Sep 24, 2024 •
edited
Loading

  • Proper subquery [in SELECT, FROM, WHERE] detection logic
  • Logic for proper handling of subqueries
  • Add new test cases to test_sql_query_filter.py file
  • Compatibility of new subquery logic with existing CTE logic (added in Subquery fix #6 pr)

@nikhil3303 nikhil3303 marked this pull request as draft September 24, 2024 20:03
@nikhil3303
Final logic for detecting and handling subqueries, fixed circular imp…
b38e278 
…ort errors with importlib, _cleanup_whitespace method is now in a separate module
@nikhil3303
Copy link
Author

nikhil3303 commented Sep 26, 2024 •
edited
Loading

  • Add end_keyword subquery detection and handling
  • Able to handle nested subqueries also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nikhil3303