Change to Docker Api #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the config to the new toml format for pylint 3.x
This removes the need to provide a root folder for the projects
These problems were also previously present, but that change that mypy now checks for compatibility with 3.8 showed this errors
This is done to seperate the different parts
This should be used for http and https connections
|
This closes #31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the interaction with docker from the cli to the api.
The API is better suited for this task, because it provides more and easier accessible information.
It also allows easier testing, because it can be mocked which wasn't the case for the cli calls.
This changes the behavior, so that all docker compose projects/services on the current host are found and not just ones that are in the root folder.
I think that I will add some way to limit the containers which are inspected by this program in a later PR