Boost: remove USE_CONFIG_FROM_BOOST hunter option, remove old #784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-tdrn
reviewed
May 30, 2025
NeroBurner
commented
May 30, 2025
|
@hjmallon could you review this PR please |
Remove the option `USE_BOOST_CONFIG`. It is now essentially always enabled. Remove all Boost versions older than 1.72, as the old versions don't supply a `BoostConfig.cmake` file yet. Remove the code and templates to create a `BoostConfig.cmake` with Hunter. Update the examples and remove the `-useBoostConfig` example folders. Fixes: #723
NeroBurner
force-pushed
the
boost_always_use_config
branch
from
b49e35a to
507e02a
Compare
|
rebased on current master to get the |
|
Sorry I have changed jobs and no long use Hunter. @JamesEggleton may be able to find someone to review it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the option
USE_BOOST_CONFIG. It is now essentially always enabled.Remove all Boost versions older than 1.72, as the old versions don't supply a
BoostConfig.cmakefile yet.Remove the code and templates to create a
BoostConfig.cmakewith Hunter.Update the examples and remove the
-useBoostConfigexample folders.Fixes: #723