Enable support for multiple kernels for xeus-cpp-lite #290
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
- Coverage 82.15% 81.30% -0.85%
==========================================
Files 20 20
Lines 958 968 +10
Branches 88 88
==========================================
Hits 787 787
- Misses 171 181 +10
🚀 New features to boost your workflow:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
Screen.Recording.2025-04-17.at.1.47.31.PM.mp4Demo above : Shows 3 xeus-cpp-lite kernels built (all use different flags -std=c++17/20/23) On top of which xcpp20 is built using the -msimd128 flag (required for running simd code in the browser) So xcpp20 kernel would work but xcpp23 wouldn't ! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -19,7 +19,7 @@ namespace xcpp | |||
| { | |||
| public: | |||
|
|
|||
| wasm_interpreter(); | |||
| wasm_interpreter(const std::vector<std::string>& args); | |||
There was a problem hiding this comment.
warning: no header providing "std::string" is directly included [misc-include-cleaner]
include/xeus-cpp/xinterpreter_wasm.hpp:14:
+ #include <string>| @@ -19,7 +19,7 @@ | |||
| { | |||
| public: | |||
|
|
|||
| wasm_interpreter(); | |||
| wasm_interpreter(const std::vector<std::string>& args); | |||
There was a problem hiding this comment.
warning: no header providing "std::vector" is directly included [misc-include-cleaner]
include/xeus-cpp/xinterpreter_wasm.hpp:14:
+ #include <vector>| @@ -32,6 +32,9 @@ namespace xcpp | |||
|
|
|||
| XEUS_CPP_API | |||
| std::string retrieve_tagfile_dir(); | |||
|
|
|||
| XEUS_CPP_API | |||
| std::pair<int, char**> convert_to_argv(const std::vector<std::string>& args); | |||
There was a problem hiding this comment.
warning: no header providing "std::pair" is directly included [misc-include-cleaner]
include/xeus-cpp/xutils.hpp:12:
+ #include <utility>| @@ -32,6 +32,9 @@ | |||
|
|
|||
| XEUS_CPP_API | |||
| std::string retrieve_tagfile_dir(); | |||
|
|
|||
| XEUS_CPP_API | |||
| std::pair<int, char**> convert_to_argv(const std::vector<std::string>& args); | |||
There was a problem hiding this comment.
warning: no header providing "std::vector" is directly included [misc-include-cleaner]
include/xeus-cpp/xutils.hpp:12:
+ #include <vector>| : interpreter(0, nullptr) | ||
| { | ||
| } | ||
| wasm_interpreter::wasm_interpreter(const std::vector<std::string>& args) |
There was a problem hiding this comment.
warning: no header providing "std::string" is directly included [misc-include-cleaner]
src/xinterpreter_wasm.cpp:15:
+ #include <string>| : interpreter(0, nullptr) | ||
| { | ||
| } | ||
| wasm_interpreter::wasm_interpreter(const std::vector<std::string>& args) |
There was a problem hiding this comment.
warning: no header providing "std::vector" is directly included [misc-include-cleaner]
src/xinterpreter_wasm.cpp:15:
+ #include <vector>|
|
||
| return { | ||
| static_cast<int>(argv_vec.size()), | ||
| const_cast<char**>(argv_vec.data()) |
There was a problem hiding this comment.
warning: do not use const_cast to remove const qualifier [cppcoreguidelines-pro-type-const-cast]
const_cast<char**>(argv_vec.data())
^
Description
Fixes #185
Type of change
Please tick all options which are relevant.