Make use of EMSDK environment variable which comes from sourcing emsdk script #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fact the EMSDK environment variable is blank when you get emsdk from Emscripten forge suggests a bug in the Emscripten Forge to me. You get this variable when you setup emsdk using the upstream repo (see https://github.com/compiler-research/CppInterOp/actions/runs/13933008473/job/38994499405#step:9:103) . |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
=======================================
Coverage 80.56% 80.56%
=======================================
Files 20 20
Lines 957 957
Branches 88 88
=======================================
Hits 771 771
Misses 186 186 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
xeus-cpp instructions create a BUILD_PREFIX and SYSROOT_PATH environment variable. It would be better to just utilise the EMSDK environment variable which comes from when you setup emsdk. Also since we only use SYSROOT_PATH once it makes no sense for it to be an environment variable. We can just put the path directly into the cmake configure stage.
Fixes # (issue)
Type of change
Please tick all options which are relevant.