Skip to content

Add query for all flow types in a runtime #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Knerio
Copy link
Member

@Knerio Knerio commented May 16, 2025

close #387

@Knerio Knerio requested a review from Taucher2003 May 16, 2025 21:42
@Knerio Knerio self-assigned this May 16, 2025
… flow_type, flow_type_setting and translation
@Knerio Knerio force-pushed the 387-query-all-flow-types-for-a-project branch from 714e3e2 to 4e126cf Compare May 16, 2025 21:44
Copy link

github-actions bot commented May 16, 2025

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/1822700688

Status: Passed
Duration: 6 minutes

Job summaries

rspec: [ee]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/10066115725/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/1822700688/test_report
Finished in 13.53 seconds (files took 10.26 seconds to load)
979 examples, 0 failures
2759 / 2946 LOC (93.65%) covered.
[TEST PROF INFO] Time spent in factories: 00:07.234 (38.54% of total time)

rspec: [ce]

Coverage report available at https://code0-tech.gitlab.io/-/development/sagittarius/-/jobs/10066115721/artifacts/tmp/coverage/index.html
Test summary available at https://gitlab.com/code0-tech/development/sagittarius/-/pipelines/1822700688/test_report
Finished in 15.98 seconds (files took 11.91 seconds to load)
932 examples, 0 failures
2606 / 2809 LOC (92.77%) covered.
[TEST PROF INFO] Time spent in factories: 00:08.214 (37.32% of total time)

rubocop

503 files inspected, no offenses detected

Copy link
Member

@Taucher2003 Taucher2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are also missing the policy changes, so that the authorize rules on the types can actually pass.

I think, read_flow_type and read_flow_type_setting should be enabled for every member. No need to have that as customizable permission.

…sion to read_flow_type(_setting), remove authorization for translations
@Knerio Knerio requested a review from Taucher2003 May 17, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query all flow types for a project
2 participants