-
-
Notifications
You must be signed in to change notification settings - Fork 119
feat: Atmos Terraform Plan Upload #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1272 +/- ##
=======================================
Coverage 49.16% 49.17%
=======================================
Files 233 233
Lines 25548 25645 +97
=======================================
+ Hits 12561 12610 +49
- Misses 11328 11370 +42
- Partials 1659 1665 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…into feat/atmos-plan-upload
} | ||
|
||
flags := cmd.Flags() | ||
|
||
component, err := flags.GetString("component") | ||
if err != nil { | ||
return ProLockUnlockCmdArgs{}, err | ||
return ProLockUnlockCmdArgs{}, fmt.Errorf("%w: %v", ErrFailedToGetComponentFlag, err) |
Check failure
Code scanning / golangci-lint
add-constant: string literal "%w: %v" appears, at least, 4 times, create a named constant for it Error
} | ||
|
||
c.Logger.Trace(fmt.Sprintf("\nUploading the affected components and stacks to %s", url)) | ||
|
||
resp, err := c.HTTPClient.Do(req) | ||
if err != nil { | ||
return fmt.Errorf("failed to make request: %w", err) | ||
return fmt.Errorf("%w: %w", ErrFailedToMakeRequest, err) |
Check failure
Code scanning / golangci-lint
add-constant: string literal "%w: %w" appears, at least, 4 times, create a named constant for it Error
Important
Work in progress!
what
why
references