add github actions #480
Merged
add github actions #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kart2bc
force-pushed
the
github-action
branch
6 times, most recently
from
7dcdb36 to
fd44bb3
Compare
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
kart2bc
force-pushed
the
github-action
branch
22 times, most recently
from
570aecc to
52fab07
Compare
kart2bc
force-pushed
the
github-action
branch
8 times, most recently
from
ed62408 to
6cbdb9e
Compare
kart2bc
force-pushed
the
github-action
branch
7 times, most recently
from
0068a77 to
5b7bb98
Compare
ameowlia
requested changes
May 19, 2025
ameowlia
reviewed
May 19, 2025
|
My main concern with this is that it seems like we are now duplicating a lot of the logic that lives in the repos and CI scripts in these workflows. However, I really want this so I'm not going to object 😄 Can we also add a job / step that checks if the generated workflow file is up-to-date? |
ameowlia
approved these changes
May 20, 2025
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
I am approving this PR, but I think this is a good idea for future improvement @maxmoehl. |
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To perform basic validations before the PR is merged to develop branch.
Validated in the forked repo: kart2bc#1
https://github.com/kart2bc/routing-release/actions/runs/15077414452/job/42388907122
The gh action setting should be enabled in the cloudfoundry/routing-release repo.
Backward Compatibility
Breaking Change? No