fix(lazy): implement instanceof properly #3287
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
May 7, 2025 14:19
Head branch was pushed to by a user without write access
rassie
force-pushed
the
lazy-instanceof
branch
2 times, most recently
from
ff3eb4e to
9146187
Compare
|
@iliapolo addressed your comments and rebased. |
iliapolo
approved these changes
May 8, 2025
Fixes: cdk8s-team/cdk8s#2164 Signed-off-by: Nikolai Prokoschenko <nikolai.prokoschenko@kurzdigital.com>
|
@rassie build is failing on some self mutation stuff. Run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same procedure as for
ApiObjectandChartback in the day.Fixes: cdk8s-team/cdk8s#2164