[FIX] Table.from_table: fix caching with reused ids #4370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EfficientTransformTests count calls to compute_values.
markotoplak
changed the title
In Table.from_table id() of objects are used as cache keys. Because ids can be reused this can be a problem. If keys were not tuples we could use WeakKeyDictionary for cache, but here, because they are, I store weakrefs to original objects as values. The cached value is not used if the objects these weakrefs are pointing to do not exists anymore.
markotoplak
force-pushed
the
from_table-cache-less
branch
from
e517c0f to
b175dfa
Compare
Codecov Report
@@ Coverage Diff @@
## master #4370 +/- ##
==========================================
+ Coverage 87.1% 87.13% +0.03%
==========================================
Files 399 399
Lines 72762 72907 +145
==========================================
+ Hits 63376 63530 +154
+ Misses 9386 9377 -9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In
Table.from_tableid() of objects are used as cache keys. Because ids can be reused this can be a problem.Description of changes
If keys were not tuples we could use WeakKeyDictionary for cache, but here, because they are, I store weakrefs to original objects as values. The cached value is not used if the objects these weakrefs are pointing to do not exists anymore.
Includes