-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[FIX] Statistics.unique: Fix Sparse Return Order For Negative Numbers #2572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11eee67
to
3a2f4f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2572 +/- ##
==========================================
- Coverage 75.83% 75.83% -0.01%
==========================================
Files 338 338
Lines 59545 59545
==========================================
- Hits 45156 45154 -2
- Misses 14389 14391 +2 |
792b230
to
08238b1
Compare
nikicc
approved these changes
Sep 12, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
08238b1
to
8add499
Compare
OK, then when #2558 is merged this just needs a rebase and IMO it's ready to merge. |
447fd36
to
bc688c8
Compare
3 tasks
326d512
to
28ceda0
Compare
Please rebase this as #2698 has been merged. |
28ceda0
to
c5a3368
Compare
c5a3368
to
3e08ba0
Compare
@nikicc Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
unique
returned incorrectly ordered arrays in case of a negative number e.g.nanunique
did not support any parameters thatunique
supported.Description of changes
Fixes above issues. This PR depends on #2698 for the
dense_sparse
testing utility.Includes