-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[FIX] Predictions widget: handle similar but different domains #2129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is misleading to show probabilities of zero for a class that did not exist in the train data. Only the probabilities for classes present in the train data should be shown.
Furthermore, even if the class of the test data is completely different than the class of the train data (all the values are different) the widget should still work. Perhaps a warning should be shown in this case.
Could you consider this PR in the light of #2183, which slightly changes the meaning of the widget's attribute If it does, I'd prefer merging #2183 first, since it fixes a more critical bug. |
It seems that with changes from #2183 the problem does not appear anymore. |
Codecov Report
@@ Coverage Diff @@
## master #2129 +/- ##
==========================================
- Coverage 72.02% 71.17% -0.86%
==========================================
Files 318 318
Lines 54580 54691 +111
==========================================
- Hits 39309 38924 -385
- Misses 15271 15767 +496 Continue to review full report at Codecov.
|
Issue
Widget throws an error similar to "index 1 is out of bounds for axis 0 with size 1". That occurs when predictions which are sent to Predictions widget are made from a data with different domain than a domain which is also sent to that widget. For instance, predictions predict only two possible target values but the data has also a third value.
https://sentry.io/biolab/orange3/issues/223474227/
https://sentry.io/biolab/orange3/issues/216151441/
Description of changes
Predictions table is extended to match the number of the data target's values.
Includes