Add CcInfo to allowed providers of py_library deps. #550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Aspect Team
This PR enables better compatibility with pybind11_bazel and makes the aspect py rules more of a drop-in replacement of the official rules_python. Please let me know if you are open to this contribution, then I can also add tests for it.
More specifically: This change is useful when using a
pybind_extension in the
deps
of apy_libary
as thepybind_extension
is just acc_binary
under the hood. This PR enables using it like so:The
py_libary
from the officialrules_python
also already supports usingCcInfo
providers in thedeps
attribute.Without this change a workaround is to wrap the
pybind_extension
in apy_library
from the officialrules_python
:Changes are visible to end-users: no
Test plan
TODO