-
Notifications
You must be signed in to change notification settings - Fork 242
Add Docker images SNAPSHOT on Docker HUB (nightly) #1593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbonofre thanks for driving this, it will be very useful!
Global suggestion: I would change the image names and tags in order to not mix up release images with nightly images:
- name: Build Server Docker image
run: |
./gradlew \
:polaris-quarkus-server:assemble \
:polaris-quarkus-server:quarkusAppPartsBuild --rerun \
-Dquarkus.container-image.build=true \
-Dquarkus.container-image.push=true \
-Dquarkus.container-image.name=polaris-nightly \
-Dquarkus.container-image.tag=$(date +%Y%m%d) \
-Dquarkus.container-image.additional-tags=""
- name: Build Admin Tool Docker image
run: |
./gradlew \
:polaris-quarkus-admin:assemble \
:polaris-quarkus-admin:quarkusAppPartsBuild --rerun \
-Dquarkus.container-image.build=true \
-Dquarkus.container-image.push=true \
-Dquarkus.container-image.name=polaris-admin-tool-nightly \
-Dquarkus.container-image.tag=$(date +%Y%m%d) \
-Dquarkus.container-image.additional-tags=""
:polaris-quarkus-server:quarkusAppPartsBuild --rerun \ | ||
:polaris-quarkus-admin:assemble \ | ||
:polaris-quarkus-admin:quarkusAppPartsBuild --rerun \ | ||
-Dquarkus.container-image.build=true \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dangling \
here
-Dquarkus.container-image.build=true \ | ||
- name: Push Docker images to Docker HUB | ||
run: | | ||
docker push apache/polaris |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only pushing the server image, not the admin tool image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adutra Thanks for the suggestion. I was planning to push only the server image, but it makes sense to push both. Then, it makes sense to use different docker image name. I will update this PR accordingly. Thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adutra I'm not sure using nightly
in the image name is good there. I would prefer in the version/tag. Thoughts ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine either way, as long as you don't use latest
for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, in apache
DockerHub scope, we can only have polaris
as image name for now. We can ask to create another apache/polaris-admin-tool
repo. However, I think it's fine to use tag/version like admin-tool-xxxx
. It's what I'm doing for the release for now.
OK ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm not really :-) we shouldn't mix different binaries under the same image name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so for now let's push only server image (polaris
). Do you want me to already create apache/polaris-admin-tool
repo ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with pushing just the server for now. If the process to create apache/polaris-admin-tool
takes time, I'd say let's start it asap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's start a discussion on the dev mailing list.
As discussed on the mailing list, this PR extends nightly build to push SNAPSHOT images on Docker HUB.