-
Notifications
You must be signed in to change notification settings - Fork 236
[Fix apache/incubator-kie-issues#1904] Add audit log messages when persiting/restoring headers #3895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Fix apache/incubator-kie-issues#1904] Add audit log messages when persiting/restoring headers #3895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is better to not mix filter logic with debugging logic.
Also, log level should be debug, not info.
...n-protobuf/src/main/java/org/jbpm/flow/serialization/impl/ProtobufProcessInstanceReader.java
Outdated
Show resolved
Hide resolved
...n-protobuf/src/main/java/org/jbpm/flow/serialization/impl/ProtobufProcessInstanceWriter.java
Outdated
Show resolved
Hide resolved
...n-protobuf/src/main/java/org/jbpm/flow/serialization/impl/ProtobufProcessInstanceWriter.java
Outdated
Show resolved
Hide resolved
7e48b68
to
850ad18
Compare
@fjtirado could you review it again? |
@gabriel-farache, @fjtirado is on PTO until May 30th. |
850ad18
to
bbb7f69
Compare
Adding @gmunozfe to the loop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabriel-farache hi, could you check this formatting error and try to fix the pipelines to be green?
Error: Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.13.0:validate (default) on project process-serialization-protobuf: File '/home/runner/work/incubator-kie-kogito-runtimes/incubator-kie-kogito-runtimes/apache_incubator-kie-kogito-runtimes/jbpm/process-serialization-protobuf/src/main/java/org/jbpm/flow/serialization/impl/ProtobufProcessInstanceReader.java' has not been previously formatted. Please format file and commit before running validation!
…rsiting/restoring headers Signed-off-by: gabriel-farache <gfarache@redhat.com>
Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
Signed-off-by: gabriel-farache <gfarache@redhat.com>
54a1bb9
to
da68f7a
Compare
Fix apache/incubator-kie-issues#1904