Skip to content

[Fix apache/incubator-kie-issues#1904] Add audit log messages when persiting/restoring headers #3895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gabriel-farache
Copy link
Contributor

Copy link
Contributor

@fjtirado fjtirado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is better to not mix filter logic with debugging logic.
Also, log level should be debug, not info.

@gabriel-farache gabriel-farache force-pushed the feat/headers_audit_log branch 2 times, most recently from 7e48b68 to 850ad18 Compare April 22, 2025 07:35
@gabriel-farache
Copy link
Contributor Author

@fjtirado could you review it again?

@ricardozanini
Copy link
Member

@gabriel-farache, @fjtirado is on PTO until May 30th.

@gabriel-farache gabriel-farache force-pushed the feat/headers_audit_log branch from 850ad18 to bbb7f69 Compare May 14, 2025 09:13
@ricardozanini ricardozanini requested a review from gmunozfe May 14, 2025 16:07
@ricardozanini
Copy link
Member

Adding @gmunozfe to the loop.

Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabriel-farache hi, could you check this formatting error and try to fix the pipelines to be green?

Error: Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.13.0:validate (default) on project process-serialization-protobuf: File '/home/runner/work/incubator-kie-kogito-runtimes/incubator-kie-kogito-runtimes/apache_incubator-kie-kogito-runtimes/jbpm/process-serialization-protobuf/src/main/java/org/jbpm/flow/serialization/impl/ProtobufProcessInstanceReader.java' has not been previously formatted. Please format file and commit before running validation!

@gabriel-farache gabriel-farache requested a review from gmunozfe June 3, 2025 08:06
gabriel-farache and others added 3 commits June 3, 2025 10:07
…rsiting/restoring headers

Signed-off-by: gabriel-farache <gfarache@redhat.com>
Co-authored-by: Francisco Javier Tirado Sarti <65240126+fjtirado@users.noreply.github.com>
Signed-off-by: gabriel-farache <gfarache@redhat.com>
@gabriel-farache gabriel-farache force-pushed the feat/headers_audit_log branch from 54a1bb9 to da68f7a Compare June 3, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log audit message when storing tokens
4 participants