Core: Catch IAE when decoding JWT #13192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…expiration time from arbitrary Bearer token that looks like jwt.
nastra
reviewed
Jun 2, 2025
| @@ -73,6 +73,10 @@ public void testOAuthScopeTokenValidation() { | |||
| public void testExpiresAt() { | |||
| assertThat(OAuth2Util.expiresAtMillis(null)).isNull(); | |||
| assertThat(OAuth2Util.expiresAtMillis("not a token")).isNull(); | |||
| assertThat( | |||
| OAuth2Util.expiresAtMillis( | |||
| "a.b.c token looks like jwt but not jwt and too short per section")) | |||
There was a problem hiding this comment.
can you just update this to a.b.c?
There was a problem hiding this comment.
Yes, of course! Thanks.
nastra
approved these changes
Jun 2, 2025
singhpk234
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
LGTM !
I realized there was one more PR open for this fix a month ago : https://github.com/apache/iceberg/pull/12955/files
nastra
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an unintentional crash with IllegalArgumentException when attempting to extract expiration time from arbitrary Bearer token that looks like jwt in OAuth2Util.
Without the change, for the newly added test:
To run the test,
./gradlew :iceberg-core:test --tests org.apache.iceberg.rest.auth.TestOAuth2Util.