chore: hms/glue catalog create table should respect default location #1302
+42
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om_table_creation
…rom_table_creation
sundy-li
changed the title
|
review cc @Xuanwo |
sdd
reviewed
May 12, 2025
sdd
requested changes
May 12, 2025
liurenjie1024
approved these changes
May 13, 2025
|
cc @sdd for another review |
sdd
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
The glue/hms catalog will throw error
Can't create table without locationif table did not have location option.We need to inject the default location before
TableMetadataBuilder::from_table_creationAre these changes tested?
unit test