-
Notifications
You must be signed in to change notification settings - Fork 255
feat(catalog): Implement MemoryCatalog's table update/ commit path #1290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…tates Signed-off-by: DerGut <jannik.steinmann@gmx.de>
Signed-off-by: DerGut <jannik.steinmann@gmx.de>
Signed-off-by: DerGut <jannik.steinmann@gmx.de>
Signed-off-by: DerGut <jannik.steinmann@gmx.de>
Signed-off-by: DerGut <jannik.steinmann@gmx.de>
Signed-off-by: DerGut <jannik.steinmann@gmx.de>
Signed-off-by: DerGut <jannik.steinmann@gmx.de>
Signed-off-by: DerGut <jannik.steinmann@gmx.de>
Signed-off-by: DerGut <jannik.steinmann@gmx.de>
Thanks for this pr! I do not think we should move forward with this yet before our transaction API is finished. This is a nice start though and can probably be added later and tested alongside the rest of the transaction functionality. |
What do you think? @liurenjie1024 @Fokko |
Works for me, happy to iterate on it later if needed 👍 Is there a ticket for pending transaction API improvements? I couldn't find one. |
#700 This holds most of the improvements for updates, deletes, etc. You can possibly look into the different pull requests that are contributing to this. |
Which issue does this PR close?
Relates to #700
This is a first attempt at implementing the commit path for the
MemoryCatalog
. Happy about any feedback!What changes are included in this PR?
This PR implements the
MemoryCatalog::update_table
method. It also adds aMetadataLocation
struct to avoid some re-validations of the location format.I'm very open to removing the
MetadataLocation
or moving it's addition to a separate PR.Are these changes tested?
So far, I've included unit tests to verify
MemoryCatalog
can be observed in the updated tableMetadataLocation